wip: add support for xx-dnf #147
Conversation
There was a problem hiding this comment.
Some lint issues https://github.com/tonistiigi/xx/actions/runs/7792252979/job/21249899199?pr=147#step:3:275
Also missing DCO: https://github.com/tonistiigi/xx/pull/147/checks?check_run_id=21249896739
Otherwise looks pretty good, thanks!
|
@panekj Do you have time to look at #147 (review) ? Also looking at #158 (comment), I wonder if it needs some wrapping for |
I think just Fedora is a nice base image to work with when you want Looking forward to this! 😎 EDIT: Oh nevermind just noticed the new commit that I think added the extra support requested? |
Yes all good! |
Sorry this took this long, I've implemented basic support while testing (https://github.com/lapce/lapce/blob/master/extra/linux/docker/fedora/Dockerfile), got slightly fed up with lack of way to test different linux distributions locally and my inner hate for shell scripts and then life stuff happened. |
It's not complete, there stuff like Lines 20 to 31 in 46e6c91 and I have yet to verify if the correct package manager is called for each action |
panekj
force-pushed
the
feat/xx-rpm
branch
3 times, most recently
from
9e268f7
to
deb6cb8
Compare
Signed-off-by: Jakub Panek <[email protected]>
|
Going through test errors of various distros will take some time, unless there is specific set that will be supported and some unsupported (e.g. would fully supporting |
I would just focus on keeping the support minimal, which makes it more evident what matters to users? My interest is in Fedora. There isn't much discussion on other distros for the feature, but you could take the stance of only officially supporting a specific set of distros/base images. Users will raise new issues regarding support when it matters then, and test coverage could be expanded at that point? |
Fixes #146
Tests are not finished, currently working on getting a Rust/C/C++ software to compile together on
amd64andarm64withfedora:39imageOpening for some early feedback/guidance about tests/code quality